Update TF to 2.12 (backport from IB/CMSSW_13_2_X/g13 branch) #8565

iarspider · 2023-06-23T08:36:47Z

No description provided.

cmsbuild · 2023-06-23T08:37:08Z

A new Pull Request was created by @iarspider for branch IB/CMSSW_13_2_X/master.

@cmsbuild, @smuzaffar, @aandvalenzuela, @iarspider can you please review it and eventually sign? Thanks.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.
cms-bot commands are listed here

protobuf.spec

grpc.spec

iarspider · 2023-06-23T09:24:37Z

Thanks for the comments, I will double check these issues.

cmsbuild · 2023-06-27T07:16:36Z

Pull request #8565 was updated.

iarspider · 2023-06-27T07:17:36Z

please test

cmsbuild · 2023-06-27T07:17:53Z

Pull request #8565 was updated.

cmsbuild · 2023-06-27T12:38:51Z

-1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-fa3c28/33412/summary.html
COMMIT: 0a7e315
CMSSW: CMSSW_13_2_X_2023-06-26-2300/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmsdist/8565/33412/install.sh to create a dev area with all the needed externals and cmssw changes.

External Build

I found compilation error when building:

Requested to quit.
Requested to quit.
Requested to quit.
* The action "build-external+opencv+4.7.0-425ccbf907d42436942c51f64d4b1191" was not completed successfully because Failed to build opencv. Log file in /data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/BUILD/el8_amd64_gcc11/external/opencv/4.7.0-425ccbf907d42436942c51f64d4b1191/log. Final lines of the log file:
/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc11/external/eigen/3bb6a48d8c171cf20b5f8e48bfb4e424fbd4f79e-2bb71f8a970ac1da8e15bb1d274b1f5d/include/eigen3/unsupported/Eigen/src/SpecialFunctions/SpecialFunctionsBFloat16.h:39:47:   required from here
/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc11/external/eigen/3bb6a48d8c171cf20b5f8e48bfb4e424fbd4f79e-2bb71f8a970ac1da8e15bb1d274b1f5d/include/eigen3/Eigen/src/Core/MathFunctions.h:1361:97: error: no matching function for call to 'isinf_impl(const float&)'
1361 | template EIGEN_DEVICE_FUNC bool (isinf)   (const T &x) { return internal::isinf_impl(x); }
|                                                                             ~~~~~~~~~~~~~~~~~~~~^~~
/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc11/external/eigen/3bb6a48d8c171cf20b5f8e48bfb4e424fbd4f79e-2bb71f8a970ac1da8e15bb1d274b1f5d/include/eigen3/Eigen/src/Core/MathFunctions.h:1848:24: note: candidate: 'template bool Eigen::internal::isinf_impl(const std::complex<_Tp>&)'
1848 | EIGEN_DEVICE_FUNC bool isinf_impl(const std::complex& x)
|                        ^~~~~~~~~~

smuzaffar · 2023-07-05T10:49:26Z

please test

@iarspider , are you still working on it?

iarspider · 2023-07-05T11:04:26Z

Yes, running a local test now.

…

On Wed, Jul 5, 2023, 12:49 Malik Shahzad Muzaffar ***@***.***> wrote: please test @iarspider <https://github.com/iarspider> , are you still working on it? — Reply to this email directly, view it on GitHub <#8565 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAE3NORIVQQY4RWX5SYO77LXOVBEBANCNFSM6AAAAAAZRIJIPI> . You are receiving this because you were mentioned.Message ID: ***@***.***>

cmsbuild · 2023-07-05T16:14:31Z

-1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-fa3c28/33559/summary.html
COMMIT: 0a7e315
CMSSW: CMSSW_13_2_X_2023-07-04-2300/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmsdist/8565/33559/install.sh to create a dev area with all the needed externals and cmssw changes.

External Build

I found compilation error when building:

* The action "build-external+professor2+2.3.3-345e5b3f5f7f9310d850731252431705" was not completed successfully because Failed to build professor2. Log file in /data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/BUILD/el8_amd64_gcc11/external/professor2/2.3.3-345e5b3f5f7f9310d850731252431705/log. Final lines of the log file:
/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc11/external/eigen/3bb6a48d8c171cf20b5f8e48bfb4e424fbd4f79e-2bb71f8a970ac1da8e15bb1d274b1f5d/include/eigen3/Eigen/src/SVD/JacobiSVD.h:607:57:   required from 'Eigen::JacobiSVD& Eigen::JacobiSVD::compute(const MatrixType&) [with MatrixType_ = Eigen::Matrix; int Options_ = 0; Eigen::JacobiSVD::MatrixType = Eigen::Matrix]'
/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc11/external/eigen/3bb6a48d8c171cf20b5f8e48bfb4e424fbd4f79e-2bb71f8a970ac1da8e15bb1d274b1f5d/include/eigen3/Eigen/src/SVD/BDCSVD.h:341:21:   required from 'Eigen::BDCSVD& Eigen::BDCSVD::compute_impl(const MatrixType&, unsigned int) [with MatrixType_ = Eigen::Matrix; int Options_ = 0; Eigen::BDCSVD::MatrixType = Eigen::Matrix]'
/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc11/external/eigen/3bb6a48d8c171cf20b5f8e48bfb4e424fbd4f79e-2bb71f8a970ac1da8e15bb1d274b1f5d/include/eigen3/Eigen/src/SVD/BDCSVD.h:205:5:   required from 'Eigen::BDCSVD::BDCSVD(const MatrixType&, unsigned int) [with MatrixType_ = Eigen::Matrix; int Options_ = 0; Eigen::BDCSVD::MatrixType = Eigen::Matrix]'
src/Ipol.cc:93:55:   required from here
/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc11/external/eigen/3bb6a48d8c171cf20b5f8e48bfb4e424fbd4f79e-2bb71f8a970ac1da8e15bb1d274b1f5d/include/eigen3/Eigen/src/QR/ColPivHouseholderQR.h:115:39: error: using invalid field 'Eigen::ColPivHouseholderQR::m_hCoeffs'
115 |         m_usePrescribedThreshold(false) {}
|                                       ^
/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc11/external/eigen/3bb6a48d8c171cf20b5f8e48bfb4e424fbd4f79e-2bb71f8a970ac1da8e15bb1d274b1f5d/include/eigen3/Eigen/src/QR/ColPivHouseholderQR.h:115:39: error: using invalid field 'Eigen::ColPivHouseholderQR::m_colsTranspositions'
/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc11/external/eigen/3bb6a48d8c171cf20b5f8e48bfb4e424fbd4f79e-2bb71f8a970ac1da8e15bb1d274b1f5d/include/eigen3/Eigen/src/QR/ColPivHouseholderQR.h:115:39: error: using invalid field 'Eigen::ColPivHouseholderQR::m_temp'
/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc11/external/eigen/3bb6a48d8c171cf20b5f8e48bfb4e424fbd4f79e-2bb71f8a970ac1da8e15bb1d274b1f5d/include/eigen3/Eigen/src/QR/ColPivHouseholderQR.h:115:39: error: using invalid field 'Eigen::ColPivHouseholderQR::m_colNormsUpdated'

cmsbuild · 2023-07-07T11:39:44Z

Pull request #8565 was updated.

iarspider · 2023-07-07T11:39:47Z

please test

smuzaffar · 2023-07-26T07:44:30Z

please test

cmsbuild · 2023-07-26T16:06:56Z

-1

Failed Tests: UnitTests RelVals-INPUT
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-fa3c28/33900/summary.html
COMMIT: b9ad108
CMSSW: CMSSW_13_3_X_2023-07-25-2300/el8_amd64_gcc11
Additional Tests: PROFILING
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmsdist/8565/33900/install.sh to create a dev area with all the needed externals and cmssw changes.

Unit Tests

I found errors in the following unit tests:

---> test SiStripDAQ_O2O_test had ERRORS

RelVals-INPUT

The relvals timed out after 4 hours.

Comparison Summary

Summary:

You potentially removed 162 lines from the logs
Reco comparison results: 28 differences found in the comparisons
DQMHistoTests: Total files compared: 48
DQMHistoTests: Total histograms compared: 3150117
DQMHistoTests: Total failures: 1560
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 3148535
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
Checked 207 log files, 159 edm output root files, 48 DQM output files
TriggerResults: no differences found

smuzaffar · 2023-07-27T08:19:58Z

@cms-sw/reconstruction-l2 , can you please check the DQM/reco comparison results here? We are trying to update Tensorflow to version 2.12 and looks like there are few differences in the tracking part. If these changes looks reasonable then we would move forward with TF 2.12 integration ( which also has some fixes for c++20 standard)

smuzaffar · 2023-07-31T10:46:43Z

+externals

cmsbuild · 2023-07-31T10:47:05Z

This pull request is fully signed and it will be integrated in one of the next IB/CMSSW_13_3_X/master IBs (but tests are reportedly failing). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

perrotta · 2023-08-01T19:51:13Z

+1

perrotta · 2023-08-01T19:51:42Z

merge

fasthadd.spec

fwyzard · 2023-08-03T16:12:51Z

This may be causing a failure in the GPU tests, reported here: cms-sw/cmssw#42460 .

* Use C++20 with more packages * Changes from review * Update env.sh * Changes from review; TF needs to be updated * Update TF to 2.12 (forward-port of #8565) * cmssw-tool-conf compiles * Remove unnecessary patch for tbb; add patch for sherpa * Update tbb.spec * Update dd4hep.spec * Update tbb.spec * Update tensorflow-sources.file --------- Co-authored-by: Malik Shahzad Muzaffar <shahzad.malik.muzaffar@cern.ch>

cmsbuild added tests-pending externals-pending pending-signatures orp-pending labels Jun 23, 2023

smuzaffar reviewed Jun 23, 2023

View reviewed changes

protobuf.spec Outdated Show resolved Hide resolved

smuzaffar reviewed Jun 23, 2023

View reviewed changes

protobuf.spec Outdated Show resolved Hide resolved

smuzaffar reviewed Jun 23, 2023

View reviewed changes

grpc.spec Outdated Show resolved Hide resolved

cmsbuild added tests-started and removed tests-pending labels Jun 27, 2023

cmsbuild added tests-rejected and removed tests-started labels Jun 27, 2023

cmsbuild added tests-started and removed tests-rejected labels Jul 5, 2023

cmsbuild added tests-rejected tests-pending and removed tests-started tests-rejected labels Jul 5, 2023

cmsbuild added tests-started and removed tests-pending labels Jul 7, 2023

cmsbuild added tests-approved and removed tests-started labels Jul 25, 2023

cmsbuild added tests-started and removed tests-approved labels Jul 26, 2023

cmsbuild added tests-rejected and removed tests-started labels Jul 26, 2023

smuzaffar approved these changes Jul 31, 2023

View reviewed changes

cmsbuild added externals-approved fully-signed and removed externals-pending pending-signatures labels Jul 31, 2023

cmsbuild added orp-approved and removed orp-pending labels Aug 1, 2023

cmsbuild merged commit 9a823ae into IB/CMSSW_13_3_X/master Aug 1, 2023

smuzaffar reviewed Aug 1, 2023

View reviewed changes

fasthadd.spec Show resolved Hide resolved

iarspider mentioned this pull request Aug 2, 2023

AVXVec: replace 2*insertf128 with 1*_mm256_set_m128d cms-sw/cmssw#42446

Merged

fwyzard mentioned this pull request Aug 3, 2023

[GPU] Unit test testEigenGPUNoFit_t failing when testing inverse 5x5 cms-sw/cmssw#42460

Closed

smuzaffar deleted the tf-2.12 branch August 6, 2023 18:25

makortel mentioned this pull request Aug 9, 2023

simplify implementation of SiPixelQualityESProducer and use multiple instances of it cms-sw/cmssw#42497

Merged

missirol mentioned this pull request Aug 9, 2023

Spurious DQM differences in MVA-related quantities (tensorflow related ?) cms-sw/cmssw#42525

Open

kpedro88 mentioned this pull request Aug 29, 2023

Use consistent abseil version in TensorFlow #8672

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update TF to 2.12 (backport from IB/CMSSW_13_2_X/g13 branch) #8565

Update TF to 2.12 (backport from IB/CMSSW_13_2_X/g13 branch) #8565

iarspider commented Jun 23, 2023

cmsbuild commented Jun 23, 2023

iarspider commented Jun 23, 2023

cmsbuild commented Jun 27, 2023

iarspider commented Jun 27, 2023

cmsbuild commented Jun 27, 2023

cmsbuild commented Jun 27, 2023

smuzaffar commented Jul 5, 2023

iarspider commented Jul 5, 2023 via email

cmsbuild commented Jul 5, 2023

cmsbuild commented Jul 7, 2023

iarspider commented Jul 7, 2023

smuzaffar commented Jul 26, 2023

cmsbuild commented Jul 26, 2023

smuzaffar commented Jul 27, 2023

smuzaffar commented Jul 31, 2023

cmsbuild commented Jul 31, 2023

perrotta commented Aug 1, 2023

perrotta commented Aug 1, 2023

fwyzard commented Aug 3, 2023 •

edited by smuzaffar

Loading

Update TF to 2.12 (backport from IB/CMSSW_13_2_X/g13 branch) #8565

Update TF to 2.12 (backport from IB/CMSSW_13_2_X/g13 branch) #8565

Conversation

iarspider commented Jun 23, 2023

cmsbuild commented Jun 23, 2023

iarspider commented Jun 23, 2023

cmsbuild commented Jun 27, 2023

iarspider commented Jun 27, 2023

cmsbuild commented Jun 27, 2023

cmsbuild commented Jun 27, 2023

External Build

smuzaffar commented Jul 5, 2023

iarspider commented Jul 5, 2023 via email

cmsbuild commented Jul 5, 2023

External Build

cmsbuild commented Jul 7, 2023

iarspider commented Jul 7, 2023

smuzaffar commented Jul 26, 2023

cmsbuild commented Jul 26, 2023

Unit Tests

RelVals-INPUT

Comparison Summary

smuzaffar commented Jul 27, 2023

smuzaffar commented Jul 31, 2023

cmsbuild commented Jul 31, 2023

perrotta commented Aug 1, 2023

perrotta commented Aug 1, 2023

fwyzard commented Aug 3, 2023 • edited by smuzaffar Loading

fwyzard commented Aug 3, 2023 •

edited by smuzaffar

Loading